Allow compilation of Vc 1.3.3 on macOS

Authored by vanyossi on Mar 31 2019, 7:31 AM.


Group Reviewers

Latest macOS (14.4.4) does not allow Vc 1.3.3 to build

The easieast solution for this is to move to Vc 1.4.1 as krita compiles fine with it. The API changes seems to not affect krita usages. (Mainly 1.4.0 changes are cleanups).

This pach for vc-1.3.3 is based on 1.4.1 changes in which the said functions are gone, It removes the offending code from Vc-1.3.3. allowing it to compile.

Test Plan

Krita was used breefly and no error or crash was observed

please advice on tests that use Vc to run and confirm no issues arise from patch.

Diff Detail

R37 Krita
Lint Skipped
Unit Tests Skipped
vanyossi created this revision.Mar 31 2019, 7:31 AM
Restricted Application added a reviewer: Krita. ยท View Herald TranscriptMar 31 2019, 7:31 AM
vanyossi requested review of this revision.Mar 31 2019, 7:31 AM
vanyossi edited the test plan for this revision. (Show Details)

Hi, @vanyossi!

Is it possible to run KisCompositionBenchmark on your system? (it is commented out in the build system atm). If it runs the same on both versions, I guess it should be okay just to update the version of Vc on OSX

Hi, @vanyossi!

If you have any problems with building the test, please just try to update to 1.4.1 and try to paint on 8-bit image and on 32-bit-float image. If both types of painting work, then it should be fine to use it

vanyossi abandoned this revision.Apr 9 2019, 9:22 PM

As spoken to dmitry: 1.3.3/patched or 1.4.1 are ok as long as it can paint on 8bit and 32bit canvases.

Decided on update to 1.4.1

  • vc will still add patches and fixes on the this branch
  • the speed decrease (if any on unix/osx) detected by dmitry on tests, is hard to detect while painting.