| ngraham | |
| astippich |
| Baloo | |
| Frameworks | |
| Windows | |
| FreeBSD |
The Windows code only shares the function signature with the other
variants, while the actual code is vastly different. One example are
path and attribute names, which are UTF-16 on Windows and UTF-8 otherwise,
but QFile::encodeName() is also called on Windows.
This fixes also two small bugs on Windows, one missing CloseHandle in
case the attribute has a size of 0, and a wrong return value in case
writing the ADS fails.
Linux: ctest
Windows/Mac/*BSD: untested
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I'd start to think about three separate files , unix_impl.cpp, windows_impl.cpp, stub_impl.cpp (although then you get API-syncing issues, probably, when only one of them is updated).
I don' t think there is gained much by splitting it, and as you said, there are also drawbacks ...
Still kind of hard to read, especially on phabricator. Anyway, a definite improvement.
Untested on anything besides linux