Fixes this bug
https://bugs.kde.org/show_bug.cgi?id=404246
Right now if you have a bunch of keyframes, select all the frames, right click, hold frames, add multiple hold frames
The frames can get truncated once they go outside the active animation timeline area.
This patch changes the active timeline area so it can fit all the available frames
Create an animation file with 10 or 11 frames of content.
Select all the frames, right click, hold frames, add multiple hold frames
Make it something like 30 frames and click ok
Result:
The timeline is expanded and the frames should all be there
| Lint Skipped |
| Unit Tests Skipped |
Hi, @scottpetrovic!
The patch works fine, please push it without further review :)
Initially I felt a bit unsure about the amount of columns you add to the timeline (I would personally use calculateSelectionMetrics() and then calculate the difference (maxColumn - minColumn)), but then I found the call to slotUpdateInfiniteFramesCount() and understood everything :) It looks fine. Though I would add a bit more words telling that "we add excessive maximum number of frames, which will be trimmed later".
| plugins/dockers/animation/timeline_frames_view.cpp | ||
|---|---|---|
| 1436 | Please be more careful with spaces, there should be exactly one space around mathematical operators :) | |
did a bit more commenting and fixed the white space.
This is pushed out...closing.
thanks for the reviews @dkazakov