When iconSize is not big enough, center aligned shortcut badges look better than top-left aligned ones.
BUG: 406037
mvourlakos |
Latte Dock |
When iconSize is not big enough, center aligned shortcut badges look better than top-left aligned ones.
BUG: 406037
For example, with iconSize = 32:
Before:
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
I think checking the iconSize is enough. Because:
What is the problem with that?
Oh, 0.4*60=24
No problem, it just was too clever!
afterwards it is ready to go...
Can you explain more about the number 58? What does "58=23" mean?
I choose 48 because I think it is the minimum size that top-left aligning still looks good.
From mathematical point of view, 58px. Is the first icon value that breaks the visual size we want for Badge, best fit is Badge to be 40% of height, but for 58px. is the first time that this is 41% going up to 50% when icon size 48px.
But you are right icon sizes 48-58 the top left alignment should look acceptable...
So, forget 1 just do 2 add a comment describing the 48px. produce a badge of 50% iconsize and above that is not acceptable for top left and we prefer a center alignment.