Dolphin: reintroduce tooltips without Baloo support
Needs ReviewPublic

Authored by i.Dark_Templar on Mar 30 2019, 6:10 PM.

Details

Reviewers
elvisangelaccio
broulik
ngraham
Group Reviewers
Dolphin
Summary

Tooltips contain only name of item and preview

Test Plan

Build dolphin with cmake -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON .. and
make sure tooltips are shown when enabled, and contain name and preview if available.

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
i.Dark_Templar created this revision.Mar 30 2019, 6:10 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 30 2019, 6:10 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
i.Dark_Templar requested review of this revision.Mar 30 2019, 6:10 PM

Without tooltip:

With tooltip (without baloo):

ngraham edited reviewers, added: Dolphin; removed: rkflx.Mar 30 2019, 6:33 PM

To be honest I'm not sure I see the point. If the only things it shows are the filename and preview, then you can get that information by turning on inline previews and not need this.

Same as for informational panel: preview of files depends on amount of screen size is used to display file size. It depends on file icon size. At least with my settings preview on tooltip (and on information panel) is bigger than preview in the central area.

Of course, there's not much point to use preview on informational panel, tooltip and big file icons with previews enabled at same time. But user can choose between these options those that are more convenient for specific user.

meven added a subscriber: meven.Mar 30 2019, 7:10 PM

It would be very useful for media files.

Unlike information panel, tooltips don't allow to play videos for me. But it can display pictures and text files.