Differential D20119

clean main.cpp
Needs RevisionPublic
Actions

Authored by carneirogustavo on Mar 30 2019, 1:12 AM.

Details

Reviewers
tcanabrava
patrickelectric
Group Reviewers
KDE Games
Summary

Signed-off-by: Gustavo Carneiro <gcarneiroa@hotmail.com>

add .arcconfig configuration file

Signed-off-by: Gustavo Carneiro <gcarneiroa@hotmail.com>

Diff Detail

Repository
R410 KPatience
Branch
clean_code
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10259
Build 10277: arc lint + arc unit
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptMar 30 2019, 1:12 AM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
carneirogustavo requested review of this revision.Mar 30 2019, 1:12 AM
aacid added a subscriber: aacid.Mar 30 2019, 10:29 AM

How is this a cleanup?

Maybe instead of removing the gametype feature you should fix it to make it work?

carneirogustavo added a comment.Apr 1 2019, 5:16 AM
In D20119#440395, @aacid wrote:

How is this a cleanup?

Maybe instead of removing the gametype feature you should fix it to make it work?

The gameList list is a null list with no items, so it did not make sense to maintain, even the old code was already commented, but we can evaluate a correction in functionality.

tcanabrava requested changes to this revision.Apr 9 2019, 8:37 AM

the adition of the phabricator configuration file is unrelated to a clean, please split in two patches.

This revision now requires changes to proceed.Apr 9 2019, 8:37 AM

Revision Contents
Changeset List

PathPackages
AM.arcconfig (5 lines)
Mmain.cpp (8 lines)

Diff 55053

View Options

.arcconfig

Loading...
View Options

main.cpp

Loading...