Differential D20117

Remove forcing the initial dir to QDir::homePath()
ClosedPublic
Actions

Authored by mschiller on Mar 29 2019, 8:20 PM.

Details

Reviewers
hein
Group Reviewers
KDE Applications
Commits
R369:8f9844b8dbb4: Remove forcing the initial dir to QDir::homePath()
Summary

This removes setting the current working dir to the home directory.
Without this patch the KPart's initial directory setting has no effect.
Also the KPart already defaults back to the home directory if nothing has been set.

BUG: 396036

Test Plan
  1. Edit Current profile
  2. change initial directory to something other than ~
  3. restart yakuake / open new tab
  4. The shells working dir should be equal to as specified in step 2

Diff Detail

Repository
R369 Yakuake
Branch
removedefaultdiroverwrite (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10257
Build 10275: arc lint + arc unit
mschiller requested review of this revision.Mar 29 2019, 8:20 PM
mschiller created this revision.
mschiller retitled this revision from Remove setting the initial dir to QDir::home() to Remove setting the initial dir to QDir::homePath().Apr 21 2019, 7:01 PM
mschiller edited the summary of this revision. (Show Details)
mschiller edited the test plan for this revision. (Show Details)
mschiller retitled this revision from Remove setting the initial dir to QDir::homePath() to Remove forcing the initial dir to QDir::homePath().Apr 26 2019, 9:36 AM
mschiller added a reviewer: KDE Applications.
hein accepted this revision.Apr 26 2019, 3:19 PM
This revision is now accepted and ready to land.Apr 26 2019, 3:19 PM
Closed by commit R369:8f9844b8dbb4: Remove forcing the initial dir to QDir::homePath() (authored by mschiller). · Explain WhyApr 26 2019, 3:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/terminal.cpp (2 lines)

Diff 55047

View Options

app/terminal.cpp

Loading...