unsigned long is typedef for quint32. Everywhere else in the code quint32 is used.
Details
Details
Diff Detail
Diff Detail
- Repository
- R16 KPMCore
- Branch
- arcpatch-D20109
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10241 Build 10259: arc lint + arc unit
src/util/externalcommand.cpp | ||
---|---|---|
197 | The signal in KJob is: void percent(KJob *job, unsigned long percent); so this change is not correct, as the size of long is not the same as int. |
Comment Actions
I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.
Comment Actions
This we can't do until KJob provides it. Which won't happen in Qt5. Hopefully in KF6.
Comment Actions
I have not changed the type for percent() signal, I have changed type for emitProgress()
Comment Actions
Changing the types of the parameters in a signal and a slot connected to it is always a bad idea.