Be consistent with rest of coding style
AbandonedPublic

Authored by shubham on Mar 29 2019, 8:49 AM.

Details

Summary

unsigned long is typedef for quint32. Everywhere else in the code quint32 is used.

Diff Detail

Repository
R16 KPMCore
Branch
arcpatch-D20109
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10241
Build 10259: arc lint + arc unit
shubham requested review of this revision.Mar 29 2019, 8:49 AM
shubham created this revision.
pino requested changes to this revision.Mar 29 2019, 8:55 AM
pino added a subscriber: pino.
pino added inline comments.
src/util/externalcommand.cpp
197

The signal in KJob is:

void percent(KJob *job, unsigned long percent);

so this change is not correct, as the size of long is not the same as int.

This revision now requires changes to proceed.Mar 29 2019, 8:55 AM
shubham updated this revision to Diff 55020.Mar 29 2019, 9:49 AM

Do not change argument type for percent(KJob*, unsigned long) signal

shubham marked an inline comment as done.Mar 29 2019, 9:50 AM
stikonas requested changes to this revision.Mar 29 2019, 6:00 PM

I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.

This revision now requires changes to proceed.Mar 29 2019, 6:00 PM
cjlcarvalho requested changes to this revision.Mar 29 2019, 6:01 PM

We also need to adapt this connect KJob to the Qt5 signals and slots syntax.

We also need to adapt this connect KJob to the Qt5 signals and slots syntax.

This we can't do until KJob provides it. Which won't happen in Qt5. Hopefully in KF6.

I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.

I have not changed the type for percent() signal, I have changed type for emitProgress()

pino added a comment.Mar 30 2019, 3:12 PM

I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.

I have not changed the type for percent() signal, I have changed type for emitProgress()

Changing the types of the parameters in a signal and a slot connected to it is always a bad idea.

shubham abandoned this revision.Mar 30 2019, 3:41 PM

Abandoned in favour of above comments