Differential D20108

Constantify nonce and some cleanup
ClosedPublic
Actions

Authored by shubham on Mar 29 2019, 7:06 AM.

Details

Reviewers
stikonas
cjlcarvalho
Group Reviewers
KDE Partition Manager
Commits
R16:281289dfbba8: Constantify nonce and some cleanup

Diff Detail

Repository
R16 KPMCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shubham requested review of this revision.Mar 29 2019, 7:06 AM
shubham created this revision.
stikonas added subscribers: cjlcarvalho, caiovosilva, abhijeet2096 and 3 others.Mar 29 2019, 10:20 AM

I don't think moving QtCrypto is right. It's not a Qt header, it belongs to QCA.

shubham edited reviewers, added: cjlcarvalho; removed: caiovosilva.Mar 29 2019, 10:24 AM
shubham updated this revision to Diff 55024.Mar 29 2019, 10:26 AM

Move QCA header outside Qt headers

stikonas accepted this revision as: stikonas.Mar 29 2019, 5:56 PM
This revision is now accepted and ready to land.Mar 29 2019, 5:56 PM
cjlcarvalho accepted this revision.Mar 29 2019, 5:58 PM
Closed by commit R16:281289dfbba8: Constantify nonce and some cleanup (authored by shubham, committed by cjlcarvalho). · Explain WhyMar 29 2019, 6:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/util/externalcommandhelper.cpp (4 lines)

Diff 55042

View Options

src/util/externalcommandhelper.cpp

Loading...