ecm_add_wayland_client_protocol: Improve error messages
ClosedPublic

Authored by apol on Mar 29 2019, 3:16 AM.

Details

Summary

Instead of passing the data from stdin, pass the path, this way if there's an error wayland-scanner will be able to tell us the file and line where it's failing.

Test Plan

Built kwayland and kwin with it

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Mar 29 2019, 3:16 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptMar 29 2019, 3:16 AM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Mar 29 2019, 3:16 AM
apol updated this revision to Diff 55012.Mar 29 2019, 3:20 AM

for generating server files too

zzag accepted this revision.Mar 29 2019, 9:06 AM
This revision is now accepted and ready to land.Mar 29 2019, 9:06 AM
zzag added a comment.Mar 29 2019, 9:14 AM

Hmm it looks like we're using ancient code option.

This revision was automatically updated to reflect the committed changes.