Differential D20105

ecm_add_wayland_client_protocol: Improve error messages
ClosedPublic
Actions

Authored by apol on Mar 29 2019, 3:16 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Frameworks
Commits
R240:6b27bbf0b954: ecm_add_wayland_client_protocol: Improve error messages
Summary

Instead of passing the data from stdin, pass the path, this way if there's an error wayland-scanner will be able to tell us the file and line where it's failing.

Test Plan

Built kwayland and kwin with it

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10234
Build 10252: arc lint + arc unit
apol created this revision.Mar 29 2019, 3:16 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptMar 29 2019, 3:16 AM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Mar 29 2019, 3:16 AM
apol updated this revision to Diff 55012.Mar 29 2019, 3:20 AM

for generating server files too

zzag accepted this revision.Mar 29 2019, 9:06 AM
This revision is now accepted and ready to land.Mar 29 2019, 9:06 AM
zzag added a comment.Mar 29 2019, 9:14 AM

Hmm it looks like we're using ancient code option.

Closed by commit R240:6b27bbf0b954: ecm_add_wayland_client_protocol: Improve error messages (authored by apol). · Explain WhyMar 29 2019, 1:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55011

View Options

find-modules/FindWaylandScanner.cmake

Loading...