Move onion skin color filtering out of combo box

Authored by scottpetrovic on Mar 28 2019, 3:43 PM.


Group Reviewers

This was a request by @Bollebib after talking with him over IRC. It sounded like this was an easier way to toggle the filtering on and off.

I also added a group toggle to turn filtering on and off. If color filtering is off, all colors are shown. I think this is more clear than the "All" option that toggles everything being checked or not.

here is a picture of what it looks like.

I made this patch on a Windows OS, so not sure how it will apply with the line endings and such.

Test Plan

Toggled colors on and off. They seemed to update correctly.

Toggling group checkbox enabled/disabled doing the color filtering (I think this is working too).

Diff Detail

R37 Krita
Lint Skipped
Unit Tests Skipped
scottpetrovic created this revision.Mar 28 2019, 3:43 PM
Restricted Application added a project: Krita. · View Herald TranscriptMar 28 2019, 3:43 PM
scottpetrovic requested review of this revision.Mar 28 2019, 3:43 PM
scottpetrovic edited the summary of this revision. (Show Details)

Updated the diff a bit. Added another color filter on the end so it matches what we had before.

Also labeled the first checkbox "none" since it is possible for frames not to have a color label.

scottpetrovic edited the summary of this revision. (Show Details)Mar 28 2019, 7:39 PM
rempt accepted this revision.Mar 29 2019, 9:02 AM
This revision is now accepted and ready to land.Mar 29 2019, 9:02 AM
scottpetrovic closed this revision.Mar 29 2019, 9:33 PM

This is pushed out... It will be in master and in Krita 4.2