Remove sender() and QVariant() conversions
AbandonedPublic

Authored by tcanabrava on Mar 28 2019, 11:36 AM.

Details

Reviewers
None
Summary

instead of having an actual signal, we can use a lambda to get
rid of the conversion to QVariant, check for sender(), check
for QAction, convert back to QVariant, convert to QString,
convert to QByteArray.

Send the values as QString directly, convert only once.

Diff Detail

Repository
R319 Konsole
Branch
preferNoConversions
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10215
Build 10233: arc lint + arc unit
tcanabrava created this revision.Mar 28 2019, 11:36 AM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 28 2019, 11:36 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Mar 28 2019, 11:36 AM
tcanabrava abandoned this revision.Mar 28 2019, 11:41 AM