Do not use C data type

Authored by shubham on Mar 27 2019, 11:09 AM.



unsigned long long is a "C" data type

Diff Detail

R16 KPMCore
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
shubham requested review of this revision.Mar 27 2019, 11:09 AM
shubham created this revision.

Hmm, do we really need this? quint64 is unsigned long long. It's just a typedef, so both can be used interchangeably. And unsigned long long is also C++ data type, not just C... Altgough, obviously this change wouldn't break anything. I guess it's just a question of code style but I didn't find any KDE recommendations. Any other opinions from other reviewers?

I did not find any other occurrences of unsigned long long, so probably quint64 is the coding style

If most of our code follows this standard of using quint64, I think that it is reasonable to maintain the other parts of it in this way.

cjlcarvalho accepted this revision.Mar 27 2019, 4:07 PM
This revision is now accepted and ready to land.Mar 27 2019, 4:07 PM
This revision was automatically updated to reflect the committed changes.