Never mind, of course master only, since it has new translated strings. @kochihwu can you provide your full name and email address so we can land this patch with correct authorship information? Thanks!

Thanks! It's great to be able to contribute to KDE.

Kochih Wu
mecca831@gmail.com

Just a side note: The extraction of the aspect ratio is completely broken before kf 5.57 in baloo/kfilemetadata, so it will show wrong results unless the data is re-indexed once kf 5.57 is used

In D20074#439492, @astippich wrote:

Just a side note: The extraction of the aspect ratio is completely broken before kf 5.57 in baloo/kfilemetadata, so it will show wrong results unless the data is re-indexed once kf 5.57 is used

Thanks for the heads-up! Seems like that issue is below Dolphin though so it should be handled elsewhere. Also this is targeted at master, which means by the time KDE Applications 19.08 is released, Frameworks 5.57 will have been in the while for months already.

In D20074#439491, @kochihwu wrote:

Thanks! It's great to be able to contribute to KDE.

Awesome, I'm glad it's been a good experience so far. If you're eager for more, you might find some ideas in here: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_status=REOPENED&keywords=usability%2C%20junior-jobs%2C%20&keywords_type=allwords&list_id=1602405&product=dolphin&product=frameworks-baloo&product=frameworks-kio&query_format=advanced