Fix Default Applications KCM window size
ClosedPublic

Authored by tigrang on Mar 26 2019, 9:58 PM.

Details

Summary

Config widgets were loading in when a service item was clicked.
This change loads all config widgets at the start so the window can be sized to the largest widget.

BUG: 398799
FIXED-IN: 5.16.0

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tigrang created this revision.Mar 26 2019, 9:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 26 2019, 9:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tigrang requested review of this revision.Mar 26 2019, 9:58 PM

Thanks, this works great. And kudos for navigating this very old and crusty code.

kcms/componentchooser/componentchooser.cpp
210

No foreach in new code. See https://www.kdab.com/goodbye-q_foreach/

Also, follow KDE coding style and always use braces for loops and conditionals.

tigrang updated this revision to Diff 54963.Mar 27 2019, 10:16 PM

Removed foreach and fixed coding style

ngraham accepted this revision.Mar 30 2019, 6:54 PM
This revision is now accepted and ready to land.Mar 30 2019, 6:54 PM
ngraham edited the summary of this revision. (Show Details)Mar 30 2019, 7:18 PM
This revision was automatically updated to reflect the committed changes.