Differential D20059

Take clang-cl into account.
Needs ReviewPublic
Actions

Authored by cmollekopf on Mar 26 2019, 9:09 AM.

Details

Reviewers
None
Group Reviewers
Windows
Summary

clang-cl is an MSVC compatible frontend for clang, and as such
takes MSVC style arguments. cmake still detects this as "Clang",
but with a separate CMAKE_CXX_SIMULATE_ID set to "MSVC".
This patch detects this case and makes sure that clang-cl ends up
with the correct set of options.

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10143
Build 10161: arc lint + arc unit
cmollekopf created this revision.Mar 26 2019, 9:09 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptMar 26 2019, 9:09 AM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
cmollekopf requested review of this revision.Mar 26 2019, 9:09 AM
cmollekopf added a comment.Mar 26 2019, 9:11 AM

There was already an earlier (abandoned) attempt at this: https://git.reviewboard.kde.org/r/128779

apol added a reviewer: Windows.Mar 26 2019, 2:29 PM
apol added a subscriber: apol.

LGTM, looks like clang-cl will be missing a few arguments though.

cmollekopf added a comment.Mar 29 2019, 7:23 AM

FWIW, I have meanwhile used this patch to build all kube dependencies on linux and osx as well, and it seems like it doesn't break anything.

I think clang-cl should receive all arguments it understands with this patch.

Revision Contents
Changeset List

Diff 54837

View Options

kde-modules/KDECompilerSettings.cmake

Loading...
View Options

kde-modules/KDEFrameworkCompilerSettings.cmake

Loading...