Fix altitude restriction log and allow restriction down to -15 degrees
ClosedPublic

Authored by TallFurryMan on Mar 26 2019, 8:40 AM.

Details

Summary

Fix Scheduler log for altitude restriction.
Lower minimum altitude restriction from 15 degrees to -15 degrees.

Test Plan

Make a schedule job trig the restriction and observe the correctness of the log in the Scheduler console.
Configure a restriction down to -15 degrees and observe as Scheduler properly honors the limit.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
TallFurryMan created this revision.Mar 26 2019, 8:40 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 26 2019, 8:40 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.Mar 26 2019, 8:40 AM

Better than the rather arbitrary limit of 15. But why -15 and not -90? And what about changing the maximum to 90 instead of 89.9?

I had the same reflection. Why -15 and not -90: I don't even know why it was 15 in the first place, so my change is the minus sign. It would take a high and isolated place to require a restriction under -15 degrees.
For 90 instead of 89.9 I think 90 is taboo in altaz/radec conversions because of the indefinite value of the azimuth. On the other hand, -90 is used for coherence with "no altitude restriction" in XML files. But agreed, there's no particular other justification.

wreissenberger accepted this revision.Mar 26 2019, 6:47 PM

OK, agreed.

This revision is now accepted and ready to land.Mar 26 2019, 6:47 PM
mutlaqja accepted this revision.Mar 27 2019, 4:01 PM
This revision was automatically updated to reflect the committed changes.