Differential D20055

Fixed initial size and content width of Activity Settings KCM
ClosedPublic
Actions

Authored by tigrang on Mar 25 2019, 11:28 PM.

Details

Reviewers
broulik
ngraham
Group Reviewers
Plasma
Commits
R122:806c4c073ff4: Fixed initial size and content width of Activity Settings KCM
Summary

Tab contents are added when KActivities::Consumer::serviceStatusChanged signal is fired which happens after the layout is set. This causes the window to be too small initially so a minimumSize is set manually.

This change also adjusts the column span to 2 for rows with a single checkbox. The contents of third column would be pushed outside the scroll area on rows where column 1 is the label and column 2 are the controls since the width of checkboxes in column 1 is too wide.

BUG: 398793
FIXED-IN: 5.16.0

Diff Detail

Repository
R122 Powerdevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tigrang created this revision.Mar 25 2019, 11:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 25 2019, 11:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tigrang requested review of this revision.Mar 25 2019, 11:28 PM
tigrang added a comment.EditedMar 25 2019, 11:30 PM

Before: https://i.imgur.com/KEHZK7S.png
After with only minSize set: https://i.imgur.com/XJ63Hzn.png
After with minSize + col span change: https://i.imgur.com/1EYeUOx.png

The alignment of the last screenshot may not be desirable so please check that. I can make the width in minimumSize bigger instead. I went with the values defined in .ui file for the widget

tigrang edited the summary of this revision. (Show Details)Mar 25 2019, 11:30 PM
ngraham accepted this revision.Mar 26 2019, 12:44 PM
ngraham added reviewers: Plasma, broulik.
ngraham added subscribers: broulik, ngraham.

LGTM, seems like the correct fix. @broulik?

This revision is now accepted and ready to land.Mar 26 2019, 12:44 PM
ngraham edited the summary of this revision. (Show Details)Mar 30 2019, 7:23 PM
Closed by commit R122:806c4c073ff4: Fixed initial size and content width of Activity Settings KCM (authored by tigrang, committed by ngraham). · Explain WhyMar 30 2019, 7:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55081

View Options

kcmodule/activities/activitypage.cpp

Loading...
View Options

kcmodule/common/actionconfigwidget.cpp

Loading...