Differential D20054

Use ellipsis in search placeholder
ClosedPublic
Actions

Authored by ognarb on Mar 25 2019, 11:02 PM.

Details

Reviewers
mlaurent
dvratil
Group Reviewers
KDE PIM
Commits
R76:e74272e0502e: Use ellipsis in search placeholder
Summary

Follow KDE Hig: https://hig.kde.org/style/writing/placeholder.html#actions

Test Plan

Build, and display search Search...

Diff Detail

Repository
R76 PIM: Event Views
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Mar 25 2019, 11:02 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 25 2019, 11:02 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
ognarb requested review of this revision.Mar 25 2019, 11:02 PM
mlaurent requested changes to this revision.Mar 26 2019, 12:52 PM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
src/todo/todoviewquicksearch.cpp
60

Why not "Search Summaries..." ?

This revision now requires changes to proceed.Mar 26 2019, 12:52 PM
ognarb added a comment.Mar 26 2019, 1:57 PM

According to the hig, we need to:

Keep the text as short as possible.

But if you prefer 'Search Summaries...', I don't have preferences. :P

mlaurent added a comment.Mar 28 2019, 7:01 AM

yep I prefer "Search Summaries..." :)

ognarb updated this revision to Diff 57385.May 2 2019, 3:10 PM

Use 'Search Summaries...' instead of 'Search...'

ognarb marked an inline comment as done.May 2 2019, 3:10 PM
dvratil accepted this revision.May 7 2019, 4:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 28 2019, 9:59 PM
Closed by commit R76:e74272e0502e: Use ellipsis in search placeholder (authored by ognarb). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/todo/todoviewquicksearch.cpp (2 lines)

Diff 58806

View Options

src/todo/todoviewquicksearch.cpp

Loading...