Differential D20048

[color-wallpaper] Align with the master FormLayout
ClosedPublic
Actions

Authored by filipf on Mar 25 2019, 6:00 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R120:b40dabdc27e4: [color-wallpaper] Align with the master FormLayout
Summary

This patch aligns the color wallpaper plugin's options with the FormLayout above it by making use of twinFormLayouts.

Test Plan

D19932 needed before testing.

Before:

After:

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Branch
color-plugin-aligned (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10117
Build 10135: arc lint + arc unit
filipf created this revision.Mar 25 2019, 6:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 25 2019, 6:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mar 25 2019, 6:00 PM
filipf edited the summary of this revision. (Show Details)Mar 25 2019, 6:02 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: Plasma, ngraham.
filipf edited the test plan for this revision. (Show Details)
filipf added a dependency: D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins.
ngraham accepted this revision.Mar 26 2019, 1:12 PM
This revision is now accepted and ready to land.Mar 26 2019, 1:12 PM
Closed by commit R120:b40dabdc27e4: [color-wallpaper] Align with the master FormLayout (authored by filipf). · Explain WhyApr 2 2019, 2:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 54791

View Options

wallpapers/color/contents/ui/config.qml

Loading...