Differential D20036

Correct math to blend color in the blur effect
ClosedPublic
Actions

Authored by andreagenor on Mar 25 2019, 2:02 AM.

Details

Reviewers
tcanabrava
patrickelectric
Commits
R374:f5d079c69e31: Correct math to blend color in the blur effect
Summary

Signed-off-by: André Agenor <andreagenor@icloud.com>

This is the old way blur effect work

Now we have better blend colors

Diff Detail

Repository
R374 KolourPaint
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
andreagenor requested review of this revision.Mar 25 2019, 2:02 AM
andreagenor created this revision.
andreagenor edited the summary of this revision. (Show Details)Mar 25 2019, 2:16 AM
andreagenor added reviewers: tcanabrava, patrickelectric.
andreagenor added a project: KDE Applications.
andreagenor edited the summary of this revision. (Show Details)Mar 25 2019, 2:21 AM
andreagenor updated this revision to Diff 54819.Mar 25 2019, 9:43 PM
andreagenor edited the summary of this revision. (Show Details)
  • Added OpenMP to optimize loops and exchange std::pow to multiply
tcanabrava requested changes to this revision.Mar 26 2019, 11:09 AM
This revision now requires changes to proceed.Mar 26 2019, 11:09 AM
andreagenor updated this revision to Diff 54850.Mar 26 2019, 12:02 PM
  • Add OpenMP as a dependency
patrickelectric added a comment.Mar 26 2019, 12:27 PM

Do you have an estimation of how fast is the code now with openmp ?

andreagenor added a comment.Mar 26 2019, 12:44 PM
In D20036#438624, @patrickelectric wrote:

Do you have an estimation of how fast is the code now with openmp ?

average 1s in large images we will need future improvement in the algorithm

tcanabrava accepted this revision.Mar 28 2019, 11:41 AM
This revision is now accepted and ready to land.Mar 28 2019, 11:41 AM
Closed by commit R374:f5d079c69e31: Correct math to blend color in the blur effect (authored by andreagenor). · Explain WhyMar 28 2019, 3:02 PM
This revision was automatically updated to reflect the committed changes.
tcanabrava added subscribers: andreagenor, patrickelectric.Apr 5 2019, 10:46 AM

OpenMP is missing, Andre is working on it.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (6 lines)
Mimagelib/effects/blitz.cpp (169 lines)

Diff 54989

View Options

CMakeLists.txt

Loading...
View Options

imagelib/effects/blitz.cpp

Loading...