A sibling commit to this commit in frameworks/kcmutils
passes down the focus to the searchbar in KPluginSelector.
BUG: 399516
FIXED-IN: 5.16.0
Depends on D20034
ngraham |
Plasma |
A sibling commit to this commit in frameworks/kcmutils
passes down the focus to the searchbar in KPluginSelector.
BUG: 399516
FIXED-IN: 5.16.0
Depends on D20034
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Thanks for the patch! But what is the sibling commit? The description is not quite clear to me.
True. The description isn't quite clear. The 'sibling commit' is this: https://phabricator.kde.org/D20034. But at the time of arc diff, I didn't know how to link to it. So I just linked them both via the BUG tag. Let me know what to correct here.
kcms/runners/kcm.cpp | ||
---|---|---|
88 | I'm not thrilled about this workaround. Any chance you can figure out why m_pluginSelector->setFocus() doesn't work all on its own? Also, don't use first-person comments in code. |
kcms/runners/kcm.cpp | ||
---|---|---|
41 | Don't need to include QTimer anymore. |
Thanks! Do you have commit access or do you need someone to land these patches for you?
This is my first patch. So I will need someone to land it.
kcms/runners/kcm.cpp | ||
---|---|---|
41 | Fixed | |
88 | My guess is parent class KCModule somehow messes up the setFocus() call in constructor. I can't be sure though; not enough knowledge on the codebase yet. But only that seems to explain the focus shifting to Defaults button in the module. My bad on the first-person comment. Fixed. |