Differential D20030

Fix compilation error due to QByteArray/QString mixup
ClosedPublic
Actions

Authored by dfaure on Mar 24 2019, 11:09 PM.

Details

Reviewers
vonreth
volkov
sitter
Commits
R486:7b03a01b181b: Fix compilation error due to QByteArray/QString mixup
R486:63fd27fbce78: Actually abort after the message that tells people to set CMAKE_INSTALL_PREFIX
Summary

main.cpp:4251:35: error: no matching function for call to ‘QByteArray::indexOf(QString&)’

Actually abort after the message that tells people to set CMAKE_INSTALL_PREFIX

Test Plan

mkdir build ; cd build ; cmake .. no longer prints out weird stuff after
the "!!!!" error message, it actually stops there as intended (AFAICS).

Diff Detail

Repository
R486 QCA Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10085
Build 10103: arc lint + arc unit
dfaure requested review of this revision.Mar 24 2019, 11:09 PM
dfaure created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Mar 24 2019, 11:10 PM
Closed by commit R486:7b03a01b181b: Fix compilation error due to QByteArray/QString mixup (authored by dfaure). · Explain Why
This revision was automatically updated to reflect the committed changes.
dfaure reopened this revision.Mar 24 2019, 11:11 PM

Stupid phabricator, grmbl, sorry for the noise.

dfaure updated this revision to Diff 54739.Mar 24 2019, 11:11 PM

remove unrelated change (now pushed)

sitter accepted this revision.Mar 25 2019, 1:59 PM
This revision is now accepted and ready to land.Mar 25 2019, 1:59 PM
Closed by commit R486:63fd27fbce78: Actually abort after the message that tells people to set CMAKE_INSTALL_PREFIX (authored by dfaure). · Explain WhyMar 29 2019, 8:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (1 line)

Diff 54739

View Options

CMakeLists.txt

Loading...