IMAPResource: Defer task if we get disconnected during login

Authored by dfaure on Mar 24 2019, 9:03 PM.



If we don't defer and try again, we just get stuck.

Test Plan

I've had that patch locally for a long while, but it's hard to force
the connection loss to happen at the exact moment for this. The fix is more
based on logical reasoning based on similar issues here and in FatCRM.

Diff Detail

R44 KDE PIM Runtime
No Linters Available
No Unit Test Coverage
Build Status
Buildable 10078
Build 10096: arc lint + arc unit
dfaure created this revision.Mar 24 2019, 9:03 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 24 2019, 9:03 PM
dfaure requested review of this revision.Mar 24 2019, 9:03 PM
ervin added a comment.Mar 25 2019, 8:13 AM

Looks fine to me.

dvratil accepted this revision.Mar 25 2019, 9:36 AM

Good catch! This might have actually been causing data loss by dropping a change replay if the login failed, so it would only remain stored in Akonadi.

This revision is now accepted and ready to land.Mar 25 2019, 9:36 AM
This revision was automatically updated to reflect the committed changes.