Differential D20027

Fix initial width/height in KCMs that use qml
ClosedPublic
Actions

Authored by tigrang on Mar 24 2019, 8:22 PM.

Details

Reviewers
apol
Commits
R102:43bfb812df95: Fix initial width/height in KCMs that use qml
Summary

This change fixes width/height for File Index Manager and Energy Information modules.

BUG: 398820

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tigrang created this revision.Mar 24 2019, 8:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 24 2019, 8:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tigrang requested review of this revision.Mar 24 2019, 8:22 PM

Note: There are modules in other packages that still need to be fixed for bug 398820 like Workspace settings in plasma-desktop.

apol accepted this revision.Mar 24 2019, 10:53 PM
apol added a subscriber: apol.

Makes sense to me. Do you have permissions to land it?

This revision is now accepted and ready to land.Mar 24 2019, 10:53 PM
ngraham added a subscriber: ngraham.Mar 24 2019, 11:30 PM

No, you'll have to do it for @tigrang. You can grab his authorship info from what's listed in https://cgit.kde.org/dolphin.git/commit/?id=1eaf5d3e0362f8d39655e973bcd29813ae98652b

@tigrang, wanna have a go at also doing this for the bugs listed in the "See Also" section in https://bugs.kde.org/show_bug.cgi?id=389585? Looks like there's a lot of low-hanging fruit if this is really all it takes!

Closed by commit R102:43bfb812df95: Fix initial width/height in KCMs that use qml (authored by tigrang, committed by apol). · Explain WhyMar 25 2019, 11:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 54760

View Options

Modules/energy/package/contents/ui/main.qml

Loading...
View Options

Modules/fileindexermonitor/package/contents/ui/main.qml

Loading...