Just to note: on OSX install both imports PyQt5.Qt and PyQt5.Qt yield the same result. This problably means that there will probably be no issues with this patch.

pyqt 5.12.1
sip 4.19.15

After last night's test, I can say this is not the fix to the pyqt situation on Windows.

See https://bugs.kde.org/show_bug.cgi?id=405796#c4

That bug should be fixed with R37:331beffd5332.

This change might still be worth considering. I don't have any comments on it though.

Seeing that this would be importing the attributes from where they are documented to be found, and seeing how we've established that this works on several platforms, I'd like to push this anyway.

I wouldn't mind, but I'm still having problems actually building PyQt support --

Traceback (most recent call last):

File "/home/boud/dev/krita/cmake/modules/FindPyQt5.py", line 5, in <module>
  import PyQt5.QtCore

So there still is something weird going on in our build scripts or the FindPyQt5.cmake file.

Heh, I was actually googling on how to get the PYQT_VERSION now we've updated to a newer PyQt... But even with these changes, I still get:

• Found SIP version: 4.19.15

Traceback (most recent call last):

File "C:/dev/krita/cmake/modules/FindPyQt5.py", line 5, in <module>
  import PyQt5.QtCore

ImportError: DLL load failed while importing QtCore: The specified module could not be found.

import PyQt5.Qt does succeed, though...

Maybe there's something wrong with my paths. PyQt was installed to

C:\dev\i-deps\lib\krita-python-libs\PyQt5\

and Python was installed to

C:\dev\i-deps\python