package Python in osx as Python.Framework
AbandonedPublic

Authored by vanyossi on Mar 24 2019, 7:01 AM.

Details

Reviewers
rempt
Group Reviewers
Krita
Summary

This patch allows to install Python.Framework into the krita bundle

ext_python
ext_sip
ext_pyqt

need to be rebuilt for the dependencies to install correctly

ext_python: installs to Frameworks/Python.Framework packaging all .py files needed and precompiling regular and optimized bytecode along with it.
ext_sip: install does not change, but cmake step copies files to appropieate places
ext_pyqt: installs to site-packages inside Python.Framwork

Patch adds new files to deal with some quirks

  • osx_fixappinstall.diff : forces extra Applications to be installed in BUILDROOT. Without it python framework install creates a directory in /Applications, which is not desired.
  • sitecustomize.py : Fixes missing site includes. Python.Framework with krita looks for sites-packages always in lib/python3.5/site-packages regardless of given configure options. This file installs in Python.Framework/Versions/3.5/lib/python3.5 as instructed by python documentation and adds missing sites on krita loading.

Changes to packaging scripts.

  • osxbuild: just added python step and enviromental variables for krita build step, needed by FindPython on cmake as it always find system python first.
  • osxdeploy: Fix all libraries and @ rpath on framework to work inside the bundle. And precompile all .py files inside the krita.app

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
vanyossi created this revision.Mar 24 2019, 7:01 AM
Restricted Application added a reviewer: Krita. · View Herald TranscriptMar 24 2019, 7:01 AM
Restricted Application added a project: Krita. · View Herald Transcript
vanyossi requested review of this revision.Mar 24 2019, 7:01 AM
vanyossi edited the summary of this revision. (Show Details)Mar 24 2019, 7:14 AM
vanyossi updated this revision to Diff 55157.Mar 31 2019, 9:25 PM

Updated patch to work with latest changes to build scripts

rempt added inline comments.Apr 1 2019, 9:40 AM
3rdparty/ext_pyqt/CMakeLists.txt
13

I don't get this change -- doesn't this break the command line?

vanyossi added inline comments.Apr 3 2019, 4:49 AM
3rdparty/ext_pyqt/CMakeLists.txt
13

you mean the break line?

vanyossi updated this revision to Diff 55860.Apr 9 2019, 9:25 PM

Updated Patch

  • pyqt options on cmake follow style for mingw to avoid any breakage
vanyossi marked 2 inline comments as done.Apr 9 2019, 9:26 PM
vanyossi abandoned this revision.Fri, Apr 26, 5:06 PM

Moved to gitlab and merged