BUG: 389963
Details
Details
- Reviewers
ngraham - Group Reviewers
Dolphin - Commits
- R824:4623e6e5ec53: Fix lengthy URLs in tooltips
To reproduce the issue (https://bugs.kde.org/show_bug.cgi?id=389963):
xattr -w user.xdg.origin.url "VeryLongUrlWithoutSpaces" file.name
Diff Detail
Diff Detail
- Repository
- R824 Baloo Widgets
- Branch
- mkrutov/20190323/fix/dolphin/tooltip_sizes
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10002 Build 10020: arc lint + arc unit
Comment Actions
To reproduce the issue (https://bugs.kde.org/show_bug.cgi?id=389963):
xattr -w user.xdg.origin.url "VeryLongUrlWithoutSpaces" file.name
This is a dirty fix; not sure what would be considered a proper one for the issue.
a) Only display hostname in label? (but then downloaded from xattr might be something that is not URL)
b) Split label into several strings (\n every X characters)? (but that would make it quite unreadable)
Comment Actions
You probably want to be using KStringHandler::rsqueeze (or in case of URLs I think we prefer eliding in the middle, ie. csqueeze)
| src/widgetfactory.cpp | ||
|---|---|---|
| 131–132 | Please put the 80 constant in a variable. Please add spaces before/after the > operator. | |
| src/widgetfactory.cpp | ||
|---|---|---|
| 107 | Space before/after = also here ;) | |
Comment Actions
Also please write a descriptive commit message and use the BUG: keyword. See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
Comment Actions
Makes sense to me and works as expected. Can you provide your full name and email address?
Comment Actions
Nathaniel, I've tried to reach to you on IRC to clarify this question, but there was no answer :)
I have my name and email both in git commits (Mikhail Krutov | mikhail.krutov on seznam.cz); and I have my old email with proper name here on Phabricator. However, I can't update my email on Phabricator for some reason; while my KDE Identity has both my old email (secondary) and new email (primary).
What do I do to make this information properly available for all future work I'll be commiting here?
Comment Actions
Sorry, I'm not on right now. I'm digging out from under a mountain of emails and review requests and fewer distractions are the only way to keep my sanity. :)
I have my name and email both in git commits (Mikhail Krutov | mikhail.krutov on seznam.cz); and I have my old email with proper name here on Phabricator. However, I can't update my email on Phabricator for some reason; while my KDE Identity has both my old email (secondary) and new email (primary).
File a sysadmin ticket (click on the star at the top of the page). They can help you out.
What do I do to make this information properly available for all future work I'll be commiting here?
My mistake, you're all good. I'll land the patch now.