Prevent context drawer from disappearing
ClosedPublic

Authored by dkardarakos on Mar 22 2019, 3:35 PM.

Details

Summary

Currently, on plasma mobile, if you navigate from a page that contains contextual actions to a page without contextual actions and back, context drawer disappears. Looking for contextual actions in pageStack.layers.currentItem only when pageStack.layers.depth > 1, then checking pageStack.currentItem and finally, checking pageStack.lastVisibleItem, we ensure that we look for contextual actions in the most relevant page.

Test Plan

On mobile, navigate from a page that contains contextual actions to a page without contextual actions and back.

Before patching:
Context drawer disappears

After patching:
Context drawer is still visible

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dkardarakos created this revision.Mar 22 2019, 3:35 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 22 2019, 3:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dkardarakos requested review of this revision.Mar 22 2019, 3:35 PM
mart accepted this revision.Apr 1 2019, 12:44 PM
This revision is now accepted and ready to land.Apr 1 2019, 12:44 PM
This revision was automatically updated to reflect the committed changes.