[about-distro] OSRelease to collect "extra" keys
ClosedPublic

Authored by sitter on Mar 22 2019, 2:00 PM.

Details

Summary

previously we'd ignore unknown keys. in preparation of moving to a library
let's instead collect them so a user of the class may also access them.

  • new extraKeys helper and extraValue getters
  • extras are always processed as String
  • test case fixture extended + now has comment variants (previously comments couldn't be tested since they were skipped as either comments or invalid/unknown lines. with the extras API we can actually verify that they do not incorrectly end up getting parsed
Test Plan

test still passes

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Mar 22 2019, 2:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 22 2019, 2:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Mar 22 2019, 2:00 PM
apol accepted this revision.Mar 22 2019, 4:14 PM
This revision is now accepted and ready to land.Mar 22 2019, 4:14 PM
This revision was automatically updated to reflect the committed changes.