Add marine indicators/boundaries
ClosedPublic
Actions

Authored by tandon on Jun 24 2016, 8:21 PM.

Details

Reviewers

nienhueser
rahn

Commits

R34:fa5de027ec2a: Add marine indicators/boundaries

Summary

Rendering

Fix for the following issue

Difficulty: EASY

Check e.g. the boundaries on the baltic sea between the islands of Germany and Denmark. They don't get rendered yet. They should be using #88b3bf

Repository

R34 Marble

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

tandon retitled this revision from to Add marine indicators/boundaries.

tandon updated this object.

tandon edited the test plan for this revision. (Show Details)

tandon added reviewers: nienhueser, rahn.

tandon set the repository for this revision to R34 Marble.

tandon added a project: Marble.

tandon added a subscriber: Marble.

tools/shp2osm/polyshp2osm.py
266	Can we have a separate tag indicator for disputed boundaries, and its own styling in Marble? Similar to other disputed boundaries/areas (see e.g. Jammu and Kashmir in the Atlas map theme in Marble and its legend)

Since OSM currently does not have any disputed tag for marine boundaries I added a custom tag for that.

Looks good, please push.

This revision is now accepted and ready to land.Jun 25 2016, 5:09 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/marble/StyleBuilder.cpp (14 lines)
M			src/lib/marble/geodata/data/GeoDataFeature.h (2 lines)
M			src/lib/marble/geodata/data/GeoDataFeature.cpp (1 line)
M			src/lib/marble/layers/GeometryLayer.cpp (2 lines)
M			src/lib/marble/osm/OsmPresetLibrary.cpp (2 lines)
M			tools/shp2osm/polyshp2osm.py (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4710			Jun 24 2016, 8:17 PM	★	★
Diff 2	4724			Jun 25 2016, 5:03 PM	★	★
Diff 3	4725	97e6652	rMARBLEfa5de027ec2a2c3b0e555c018dee7bf50e263a30	Jun 25 2016, 5:08 PM	★	★