Differential D19963

Avoid serializing base64 encoded favicon data twice
ClosedPublic
Actions

Authored by bruns on Mar 22 2019, 2:38 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R856:c3611dc98170: Avoid serializing base64 encoded favicon data twice
Summary

The URL is ignored in case the image data is available. Avoid pushing
it twice via DBus.

Test Plan
  1. start dbus-monitor
  2. type some string in krunner
  • before: dict entries contain both favIconData and favIconUrl, with identical data
  • after: only favIconData is part of the dict

Favicons are still shown in the krunner results

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Mar 22 2019, 2:38 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 22 2019, 2:38 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Mar 22 2019, 2:38 AM
bruns edited the test plan for this revision. (Show Details)Mar 29 2019, 5:13 PM

Ping!

broulik accepted this revision.Apr 5 2019, 2:07 PM
This revision is now accepted and ready to land.Apr 5 2019, 2:07 PM
Closed by commit R856:c3611dc98170: Avoid serializing base64 encoded favicon data twice (authored by bruns). · Explain WhyApr 5 2019, 11:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/extension.js (1 line)

Diff 55509

View Options

extension/extension.js

Loading...