Add styling for antarctic ice shelves
ClosedPublic

Authored by tandon on Jun 24 2016, 6:27 PM.

Details

Summary

Rendering

Only ice shelves

Ice shelves along with normal glaciers

Issues/Questions
For rendering these ice shelves the following tag has been used
<tag k='glacier:type' v='shelf' /> which is a proposed glacier tag(http://wiki.openstreetmap.org/wiki/Proposed_features/Glaciers_tags). This tag is to be used in conjugation with <tag k='natural' v='glacier' /> i.e both of these tags have to be present so as to express an ice shelf. (however for now the shp2osm converter assigns only the former tag for expressing an ice shelf for correct rendering)
Now to render ice shelves a new visual category has been created(NaturalIceShelf). Since currently there is only one to one mapping between an osm tag(key - value pair) to a visual category, I have mapped NaturalIceShelf to OsmTag( "glacier:type", "shelf" ). However there also exists a mapping for OsmTag( "natural", "glacier" ) to NaturalGlaceir for rendering regular glaciers. It can happen that a regular OSM file containing both of these tags may not get rendered correctly since it may get assigned any styling instead of the right one.
What must be done in such a scenario ? (should a many OSM tags to one visual category map be introduced instead of the current one to one map in OsmPresetLibrary or should things be left as they are for now)

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tandon updated this revision to Diff 4708.Jun 24 2016, 6:27 PM
tandon retitled this revision from to Add styling for antarctic ice shelves.
tandon updated this object.
tandon edited the test plan for this revision. (Show Details)
tandon added reviewers: nienhueser, rahn.
tandon set the repository for this revision to R34 Marble.
nienhueser edited edge metadata.Jun 25 2016, 6:02 AM

What about introducing a special case in OsmPresetLibrary::determineVisualCategory to handle the distinction between glaciers and ice shelves?

tandon updated this revision to Diff 4720.Jun 25 2016, 1:57 PM
tandon edited edge metadata.

Corrected the diff to handle the conflicting case.

Looks great :)

tools/shp2osm/polyshp2osm.py
252

shouldn't this set natural=glacier as well now?

tandon updated this revision to Diff 4726.Jun 25 2016, 5:24 PM
tandon marked an inline comment as done.

Added the natural=glacier tag.

nienhueser accepted this revision.Jun 25 2016, 5:41 PM
nienhueser edited edge metadata.

Looks good, please push.

This revision is now accepted and ready to land.Jun 25 2016, 5:41 PM
This revision was automatically updated to reflect the committed changes.