Small cleanups for qml components

Authored by pvuorela on Mar 21 2019, 3:24 PM.


  • Delete doesn't need null protection
  • Removed some non-functional texteditor parts, shouldn't have any functional effects
  • Global::loadPlugins is empty and not used, removed

Diff Detail

R8 Calligra
Lint Skipped
Unit Tests Skipped
pvuorela created this revision.Mar 21 2019, 3:24 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptMar 21 2019, 3:24 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
pvuorela requested review of this revision.Mar 21 2019, 3:24 PM
leinir added inline comments.Mar 27 2019, 12:40 PM

What happens to this signal now?

pvuorela added inline comments.Mar 27 2019, 1:23 PM

Nothing, but that's how it used to be. The intention might have been different, but effectively it's two disconnects without actual connection appearing anywhere as far as I can tell. And then again don't think the ::textEditor() getter should really be a place for adjusting any connections anyway.

leinir accepted this revision.Mar 27 2019, 1:28 PM
leinir added inline comments.

Hmm... Think that this was probably something not yet ported from the old Qt Quick 1 components, which had considerably more editing functionality than the QtQuick2 components... it would be good to have that restored, but yeah, for now at any rate, it does seem to have little effect.

This revision is now accepted and ready to land.Mar 27 2019, 1:28 PM
This revision was automatically updated to reflect the committed changes.