Small cleanups for qml components
ClosedPublic
Actions

Authored by pvuorela on Mar 21 2019, 3:24 PM.

Details

Reviewers

leinir

Commits

R8:35ec7cff51c2: Small cleanups for qml components

Summary

Delete doesn't need null protection
Removed some non-functional texteditor parts, shouldn't have any functional effects
Global::loadPlugins is empty and not used, removed

Repository

R8 Calligra

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript

pvuorela requested review of this revision.Mar 21 2019, 3:24 PM

components/Document.cpp
221	What happens to this signal now?

components/Document.cpp
221	Nothing, but that's how it used to be. The intention might have been different, but effectively it's two disconnects without actual connection appearing anywhere as far as I can tell. And then again don't think the ::textEditor() getter should really be a place for adjusting any connections anyway.

leinir added inline comments.

components/Document.cpp
221	Hmm... Think that this was probably something not yet ported from the old Qt Quick 1 components, which had considerably more editing functionality than the QtQuick2 components... it would be good to have that restored, but yeah, for now at any rate, it does seem to have little effect.

This revision is now accepted and ready to land.Mar 27 2019, 1:28 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			components/Document.h (2 lines)
M			components/Document.cpp (51 lines)
M			components/Global.h (1 line)
M			components/Global.cpp (10 lines)
M			components/ImageDataItem.cpp (4 lines)
M			components/impl/PresentationImpl.cpp (6 lines)
M			components/impl/SpreadsheetImpl.cpp (6 lines)
M			components/impl/TextDocumentImpl.cpp (6 lines)
M			components/models/ContentsModel.cpp (9 lines)