Explicitly set charset to UTF-8
ClosedPublic

Authored by luc4 on Mar 20 2019, 11:22 PM.

Details

Summary

Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
luc4 created this revision.Mar 20 2019, 11:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 20 2019, 11:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
luc4 requested review of this revision.Mar 20 2019, 11:22 PM

Nice :)

I have some suggestions to prevent such errors in the future:

  • sass (but not sassc) has -E option to set the encoding for building
  • it may be a good idea to add such lines to all the SCSS files

BTW, where does the build error happen?

luc4 added a comment.Mar 21 2019, 6:30 AM

Happened on KDE Neon in docker.

luc4 updated this revision to Diff 54514.Mar 21 2019, 10:23 PM

I added the explicit charset to all scss files.

gepardo accepted this revision.Mar 21 2019, 10:31 PM
This revision is now accepted and ready to land.Mar 21 2019, 10:31 PM
ngraham accepted this revision.Mar 22 2019, 11:32 AM
ngraham added a subscriber: ngraham.

Do you have commit access?

luc4 added a comment.Mar 22 2019, 11:41 AM

Hello. No, sorry, I don't think I have it.

luc4 added a comment.Mar 23 2019, 2:20 PM

Should I do something else or will someone else take care of committing?

I'll commit it for you (sorry for the delay, I was traveling). Can you provide your full name and email address so I can land it with proper attribution?

luc4 added a comment.EditedMar 24 2019, 3:09 PM

Thank you: "Luca Carlon <carlon.luca@gmail.com>".

ngraham retitled this revision from Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error. to Explicitly set charset to UTF-8.Mar 24 2019, 3:14 PM
ngraham edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.

Thanks for the contribution and for your patience!