Split up subcategories for KNS categories
ClosedPublic

Authored by leinir on Mar 20 2019, 6:06 PM.

Details

Summary

This adds functionality to programmatically add subcategories (with a suitable warning not to do so after the initialisation stage), and uses that to perform a splitting of the subcategories supplied the KNewStuff backend.

Test Plan

Previously: Many categories, with annoying and bad readability
With patch: A nice dig-down tree of categories in the KDE Store applications category

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Mar 20 2019, 6:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 20 2019, 6:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir requested review of this revision.Mar 20 2019, 6:06 PM
leinir planned changes to this revision.Apr 9 2019, 12:26 PM
leinir added inline comments.
libdiscover/backends/KNSBackend/KNSBackend.cpp
149

Just realised how spammy these bits of debug are. Gone momentarily.

leinir updated this revision to Diff 55813.Apr 9 2019, 12:28 PM
leinir marked an inline comment as done.

Remove unnecessary (very noisy) debug messages

apol accepted this revision.Apr 9 2019, 8:48 PM

LGTM otherwise

libdiscover/backends/KNSBackend/KNSBackend.cpp
149

const auto&

This revision is now accepted and ready to land.Apr 9 2019, 8:48 PM
This revision was automatically updated to reflect the committed changes.