Differential D19921

RFC: Fix wayland backend initialisation
ClosedPublic
Actions

Authored by apol on Mar 20 2019, 4:39 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:6d37ce7f363d: RFC: Fix wayland backend initialisation
Summary

Otherwise it thinks outputs couldn't be created and it leaves.
Problem is that after this fix it crashes when it actually does things with:
kwin_wayland: /home/apol/devel/frameworks/kwin/composite.cpp:646: void KWin::Compositor::aboutToSwapBuffers(): Assertion `!m_bufferSwapPending' failed.

Test Plan

As said, it proceeds correctly and crashes elsewhere

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint SkippedExcuse: no cppcheck
Unit
No Unit Test Coverage
Build Status
Buildable 9913
Build 9931: arc lint + arc unit
apol created this revision.Mar 20 2019, 4:39 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 20 2019, 4:39 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
apol requested review of this revision.Mar 20 2019, 4:39 PM
davidedmundson added a subscriber: davidedmundson.Mar 20 2019, 5:24 PM

I don't get a crash and the patch itself is correct.

If there is another issue, we still need this. Ship it!

davidedmundson accepted this revision.Mar 20 2019, 5:27 PM
This revision is now accepted and ready to land.Mar 20 2019, 5:27 PM
Closed by commit R108:6d37ce7f363d: RFC: Fix wayland backend initialisation (authored by apol). · Explain WhyMar 20 2019, 5:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 54431

View Options

plugins/platforms/wayland/egl_wayland_backend.cpp

Loading...