Differential D19908

[ConfigModule] Pass initial properties
ClosedPublic
Actions

Authored by broulik on Mar 20 2019, 10:12 AM.

Details

Reviewers
mart
apol
Group Reviewers
Plasma
Commits
R296:238a49139fd6: [ConfigModule] Pass initial properties in push()
Test Plan

There's probably some std algo for it but std::copy didn't work so I gave up.

did kcm.push("SomePage.qml", {title: "foo"}) and the new page had the title I passed in

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 20 2019, 10:12 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 20 2019, 10:12 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Mar 20 2019, 10:12 AM
broulik added a comment.Apr 9 2019, 6:43 PM

Pingeliping

apol accepted this revision.Apr 9 2019, 8:52 PM
This revision is now accepted and ready to land.Apr 9 2019, 8:52 PM
Closed by commit R296:238a49139fd6: [ConfigModule] Pass initial properties in push() (authored by broulik). · Explain WhyApr 11 2019, 7:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/quickaddons/configmodule.cpp (9 lines)

Diff 55969

View Options

src/quickaddons/configmodule.cpp

Loading...