Krita crashes when selecting transform tool while using a colorize mask
ClosedPublic

Authored by ashwind on Mar 20 2019, 9:43 AM.

Details

Summary

Krita crashes when the transform tool is selected while using a colorize mask in the layer stack with edit-key-strokes option set to OFF.

BUG: 404759
FIXED-IN: krita 4.2.0-pre-alpha (git 9429230)

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
ashwind requested review of this revision.Mar 20 2019, 9:43 AM
ashwind created this revision.
rempt requested changes to this revision.Mar 20 2019, 10:20 AM
rempt added a subscriber: rempt.
rempt added inline comments.
plugins/tools/tool_transform2/kis_tool_transform.h
127 ↗(On Diff #54393)

I think that since this also occurs in KisToolPaint, we should move the enum to KisTool instead of duplicating it here. The same goes for the actual nodePaintability() method.

This revision now requires changes to proceed.Mar 20 2019, 10:20 AM

Also note that the FIXED-In tag is wrong: this commit won't go into the 4.1 branch :-)

ok i will move it to kistool instead.

ashwind updated this revision to Diff 54467.Mar 21 2019, 8:03 AM
ashwind edited the summary of this revision. (Show Details)

There was a naming conflict using NONE, in NodePaintAbility enum so I renamed it to NA.

rempt added a comment.Mar 21 2019, 8:13 AM
There was a naming conflict using NONE, in NodePaintAbility enum so I renamed it to NA.

Better name it to OTHER or UNPAINTAIBLE, so we don't have to guess what the abbreviation means.

ashwind updated this revision to Diff 54468.Mar 21 2019, 8:26 AM

Updated the diff

rempt accepted this revision.Mar 21 2019, 8:40 AM
This revision is now accepted and ready to land.Mar 21 2019, 8:40 AM
dkazakov accepted this revision.Mar 21 2019, 9:08 AM

rempt I dont have push access.

Name: Ashwin Dhakaita
Email: ashwingpdhakaita@gmail.com

This revision was automatically updated to reflect the committed changes.