Differential D19903

Fix build with msvc
Needs RevisionPublic
Actions

Authored by vonreth on Mar 20 2019, 7:51 AM.

Details

Reviewers
mlaurent
davidedmundson
aacid
Summary

For the decltype change see https://stackoverflow.com/a/51347067

Diff Detail

Repository
R159 KActivities Statistics
Branch
master
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 9889
Build 9907: arc lint + arc unit
vonreth created this revision.Mar 20 2019, 7:51 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 20 2019, 7:51 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vonreth requested review of this revision.Mar 20 2019, 7:51 AM
vonreth added reviewers: mlaurent, davidedmundson, aacid.Mar 20 2019, 7:53 AM

btw

.vim-template:cpp
.vim-template:h

aren't valid file names on windows, and look strange for unix too

aacid added a comment.Mar 20 2019, 8:21 PM

Which MSVC is that? it seems the decltype change is workarounding non C++14 support?

vonreth added a comment.Mar 20 2019, 10:09 PM

Msvc2017.
I think frameworks is still c++11?

aacid added a comment.Mar 20 2019, 10:38 PM
In D19903#435469, @vonreth wrote:

Msvc2017.
I think frameworks is still c++11?

Not sure, probably yes.

vonreth added a comment.Mar 25 2019, 2:06 PM

So then the workaround is correct, I haven't tried whether the original code compiles with CMAKE_CXX_STANDARD=17

aacid accepted this revision.Mar 25 2019, 7:29 PM

I don't know who is responsible for this, but noone seems to disagree, so if this fixes the build for MSVC and doesn't break other platforms let's go for it?

This revision is now accepted and ready to land.Mar 25 2019, 7:29 PM
vonreth added inline comments.Jun 11 2019, 11:17 AM
src/utils/lazy_val.h
41

Hm recently found out that this code doesn't compile with gcc.....

aacid requested changes to this revision.Jul 21 2019, 8:52 AM

yep, having it build with gcc is important :)

This revision now requires changes to proceed.Jul 21 2019, 8:52 AM

Revision Contents
Changeset List

PathPackages
Msrc/resultset.h (14 lines)
Msrc/resultset_iterator.cpp (7 lines)
Msrc/utils/lazy_val.h (2 lines)

Diff 54391

View Options

src/resultset.h

Loading...
View Options

src/resultset_iterator.cpp

Loading...
View Options

src/utils/lazy_val.h

Loading...