We also want to be able to show the spam status in 5.2 header
Details
Details
Diff Detail
Diff Detail
- Repository
- R81 KDE PIM Addons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This is how it looks afterwards:
(on the left side it is the settings dialog, that I changed to from "show spam status in fancy headers" -> "show spam status in headers"
Comment Actions
Just wondering: since we support 3rd party themes that might or might not support spam status, does it even make sense to have the option in the settings? You enable the option and then install a theme that does not support it -> bug (from user's point of view).
Wouldn't it be better - even from security point of view - to *always* show the spam status header? The only exception would be if there is no spam status information in the mail headers of course.
Comment Actions
+1 get rid of this optionin the gerneral settings, and make the themes responsible for that.
| plugins/messageviewerheaderplugins/defaultgrantleeheaderstyleplugin/theme/5.2/header.html | ||
|---|---|---|
| 83 | (a little bit unrelated) [...]
{% if header.ListId %}
<div class="row">
<div class="headerleft">{% i18n "List-Id:" %}</div>
<div class="headerright">{{ header.ListId }}</div>
</div>
{% endif %}
<div class="row">
<div class="headerleft">{% i18n "Date:" %}</div>
<div class="headerrightdate" dir="{{ dateDir }}">{{ header.dateshort }}</div>
</div>
{% if header.spamHTML %}
<div class="row">
<div class="headerleft">{% i18n "Spam status:" %}</div>
[...] | |
| plugins/messageviewerheaderplugins/defaultgrantleeheaderstyleplugin/theme/5.2/header.html | ||
|---|---|---|
| 83 | The advantage of having the strings coming from KMail is that it also provides localization for 3rd party themes. (the harcoded List-Id string is wrong of course, should be also localizable). | |
Comment Actions
Agreed: If we have spam status information, it should be shown, and if users don't like it, they can switch to a theme that does not show them.
It might be nice if we could provide at least one theme variant that does not have spam status ourselves (and says that in the name) so that users have an easy way to get rid of the spam status field.
| plugins/messageviewerheaderplugins/defaultgrantleeheaderstyleplugin/theme/5.2/header.html | ||
|---|---|---|
| 83 | +1 don't move i18n in grantlee support otherwise we will lose translation for other theme. | |
Comment Actions
We have already have an option to show or not spam status. So not necessary to add a new one.
Comment Actions
My suggestion was to actually remove the option completely and just always show the spam status. It's a security feature after all, why should anyone ever want to disable this?
Comment Actions
So to summerize:
- spam status in 5.2 theme
- delete config for disable spam status completly
- fix notranslated header fields ( in seperate patch)
- add a 5.2 variant without spam header y/n?
- do not use i18n grantlee support for string, that will be also put into others themes
| plugins/messageviewerheaderplugins/defaultgrantleeheaderstyleplugin/theme/5.2/header.html | ||
|---|---|---|
| 83 | but external apps can also load the translations of messageviewer/ kdepim-addons so we would not nessarily loos the that with grantlee i18n support. But in the end it is a code desgin desision. | |
Comment Actions
"add a 5.2 variant without spam header y/n?"
For me we mustn't create a new theme for just add or not spam status.
Otherwise we don't remove settings in kmail to show or not spam status and we fixed problem :)