[KickerDash] Add missed argument in addFavorite
ClosedPublic

Authored by trmdi on Mar 19 2019, 6:37 PM.

Details

Test Plan

Before:

  • Drag&Drop an item from the middle column into the Favorite column at the position 2 (index =1) -> it is always added at the last position

After:

  • Drag&Drop an item from the middle column into the Favorite column at the position 2 (index =1) -> it is added at the wanted position 2

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10056
Build 10074: arc lint + arc unit
trmdi created this revision.Mar 19 2019, 6:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 19 2019, 6:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
trmdi requested review of this revision.Mar 19 2019, 6:37 PM
trmdi abandoned this revision.Mar 19 2019, 6:38 PM
trmdi updated this revision to Diff 54699.Mar 24 2019, 5:56 PM

Change the target of the patch

Which bug are we fixing? A bit more context would be helpful. :)

trmdi retitled this revision from Fix "Tooltip can not be displayed" to [KickerDash] Add missed argument in addFavorite.Mar 24 2019, 6:00 PM
trmdi edited the test plan for this revision. (Show Details)
trmdi added a reviewer: ngraham.
trmdi added reviewers: hein, Plasma.
trmdi added a comment.Mar 24 2019, 6:08 PM

Which bug are we fixing? A bit more context would be helpful. :)

I can't find any one in the bug tracker, but you can easily reproduce it like I said at "Before" in the "Test Plan".

trmdi edited the test plan for this revision. (Show Details)Mar 24 2019, 6:24 PM
ngraham accepted this revision.Mar 25 2019, 12:29 AM

Whoops! Nice catch.

This revision is now accepted and ready to land.Mar 25 2019, 12:29 AM
This revision was automatically updated to reflect the committed changes.