Add runtime guard that pages are KCMs in KCMultiDialog
ClosedPublic
Actions

Authored by davidedmundson on Mar 19 2019, 5:24 PM.

Details

Reviewers

aacid

Commits

Summary

This situation can come up if a KCMultiDialog subclass adds pages
directly that aren't KCModules.

BUG: 405440

Test Plan

acheronuk tested this patch on a crashing example

Repository

R295 KCMUtils

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

davidedmundson requested review of this revision.Mar 19 2019, 5:24 PM

Patch seemed to fix the crash. I don't use Kontact (apart from testing things like this), but on a quick test all seems functional once more.

Approving since it's similar to what i did in https://phabricator.kde.org/D19889

This revision is now accepted and ready to land.Mar 19 2019, 6:54 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kcmultidialog.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	54341	6e3d4ad		Mar 19 2019, 5:24 PM	★	★
Diff 2	54394	6e3d4ad	R295:d9ddd3524535ecb5debc2157ddf02922b6bb1685	Mar 19 2019, 5:24 PM	★	★