Differential D19864

Set correct libname on debian systems as well
ClosedPublic
Actions

Authored by jbbgameich on Mar 18 2019, 6:50 PM.

Details

Reviewers
mpyne
Group Reviewers
kdesrc-build
Commits
R365:74d70dec915a: session-env: Set correct libname on Debian systems.

Diff Detail

Repository
R365 kdesrc-build
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jbbgameich requested review of this revision.Mar 18 2019, 6:50 PM
jbbgameich created this revision.
jbbgameich added a reviewer: kdesrc-build.
mpyne added a subscriber: mpyne.Mar 23 2019, 3:36 PM

I have a question, and also it would be good to know if there's a standardized convention for this kind of detection between Debian, BSD, Fedora, etc. etc.

sample-kde-env-master.sh
88

Shouldn't this test come after the lib64 check? This seems to me like a less common convention so I don't think it should be checked first.

jbbgameich added a comment.Mar 23 2019, 11:19 PM
This comment was removed by jbbgameich.
jbbgameich added inline comments.Mar 23 2019, 11:20 PM
sample-kde-env-master.sh
88

This was done on purpose, since /usr/lib64 also exists on debian systems, although it only contains /usr/lib64/ld-linux-x86-64.so.2.
Afaik /usr/lib/x86_64-linux-gnu doesn't exist on non-debian based distributions though.

mpyne accepted this revision.Mar 26 2019, 1:51 AM

Right then, sounds good.

This revision is now accepted and ready to land.Mar 26 2019, 1:51 AM
Closed by commit R365:74d70dec915a: session-env: Set correct libname on Debian systems. (authored by jbbgameich, committed by mpyne). · Explain WhyMay 4 2019, 8:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msample-kde-env-master.sh (4 lines)

Diff 57573

View Options

sample-kde-env-master.sh

Loading...