Differential D1985

Improve gdb plugin unit tests
ClosedPublic
Actions

Authored by qi437103 on Jun 23 2016, 7:46 PM.

Details

Reviewers

apol
kfunk

Group Reviewers

KDevelop

Commits

R32:9cb910b95eee: Improve gdb plugin unit tests

Summary

This is a side effect of my work on lldb plugin unit tests, in which I tried to fix the somewhat unreliable test results.

Move unit test debugees to common folder, make gdb uses common unit test helpers
Make gdb plugin unit tests more reliable. waitForState now guarantees the session state after returning is exactly the requested one (otherwise fails the test).

The main problem is that DebugSession could end and get deleted when running event loop (i.e. in QTest::qWait).
And this fix adds proper checks to it. This by itself doesn't fix any tests, but it helps when some tests
did goes wrong. Without this fix, they could crash the whole test process due to accessing to deleted object.

Test Plan

gdb plugin unit tests (and actually some lldb plugin unit tests, which is only on local yet)

Diff Detail

Repository

R32 KDevelop

Branch

common-unittest

Lint

No Linters Available

Unit

No Unit Test Coverage

qi437103 updated this revision to Diff 4693.Jun 23 2016, 7:46 PM

qi437103 retitled this revision from to Improve gdb plugin unit tests.

qi437103 updated this object.

qi437103 edited the test plan for this revision. (Show Details)

qi437103 added a reviewer: apol.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 23 2016, 7:46 PM

qi437103 added a reviewer: KDevelop.Jun 23 2016, 7:47 PM

apol added inline comments.Jun 24 2016, 7:13 PM

debuggers/common/unittest/unittest.cpp
35	That's plenty of specific code without little reason. Try to keep unit tests autocontained and leverage QtTest

See Aleix' comments

This revision now requires changes to proceed.Jun 26 2016, 9:10 PM

qi437103 added inline comments.Jun 28 2016, 1:14 AM

debuggers/common/unittest/unittest.cpp
35	Could you elaborate more on this? Did you mean findExecutable and findSourceFile (which might be possible to be replaced by QFINDTESTDATA), or the whole attempt moving debugees to common? AFAIK, other functions (checking attach, comparing model data and session state waiting) are good candidates to be shared between lldb and gdb plugin.

It's great to share MI parsing code, it's fine to share some dummy structures, but we should keep the code separate between both plugins.

For example it's fine to have the attach process code duplicated, because they will have eventually different features, especially considering the different platforms.

The actual work must be getting the features to work, not to move code around.

Second attempt
No more code sharing between lldb and gdb unittests. Just the reliability improvement for gdb unittest.

Rebase on latest master

Fix gdb unit test COMPARE won't stop the test if failed.

apol accepted this revision.Jul 11 2016, 11:00 AM

apol edited edge metadata.

qi437103 mentioned this in D2178: Improve gdb plugin unit tests for 5.0 branch.Jul 14 2016, 9:01 PM

This looks good. And since the other patch got accepted as well: +1

This revision is now accepted and ready to land.Jul 15 2016, 9:26 AM

qi437103 mentioned this in R32:ec1488f41772: Improve gdb plugin unit tests for 5.0 branch.Jul 15 2016, 5:27 PM

Closed by commit R32:9cb910b95eee: Improve gdb plugin unit tests (authored by qi437103). · Explain WhyJul 15 2016, 5:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		debuggers/CMakeLists.txt (18 lines)
M		debuggers/common/CMakeLists.txt (14 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/CMakeLists.txt (20 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/debugee space.cpp (23 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/debugee.cpp (41 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/debugeecrash.cpp (31 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/debugeeexception.cpp (37 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/debugeemultilocbreakpoint.cpp (35 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/debugeemultiplebreakpoint.cpp (53 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/debugeeqt.cpp (31 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/debugeerecursion.cpp (32 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/debugeeslow.cpp (37 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/debugeethreads.cpp (42 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/path with space/CMakeLists.txt (2 lines)
V		debuggers/{common/unittest/debugees ← gdb/unittests}/path with space/spacedebugee.cpp (31 lines)
A	M	debuggers/common/unittest/unittest.h (82 lines)
A	M	debuggers/common/unittest/unittest.cpp (155 lines)
M		debuggers/gdb/CMakeLists.txt (20 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/CMakeLists.txt (20 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/debugee space.cpp (23 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/debugee.cpp (41 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/debugeecrash.cpp (31 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/debugeeexception.cpp (37 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/debugeemultilocbreakpoint.cpp (35 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/debugeemultiplebreakpoint.cpp (53 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/debugeeqt.cpp (31 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/debugeerecursion.cpp (32 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/debugeeslow.cpp (37 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/debugeethreads.cpp (42 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/path with space/CMakeLists.txt (2 lines)
V		debuggers/{gdb/unittests → common/unittest/debugees}/path with space/spacedebugee.cpp (31 lines)
M		debuggers/gdb/unittests/test_gdb.h (4 lines)
M		debuggers/gdb/unittests/test_gdb.cpp (96 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4693	97bb043		Jun 23 2016, 7:46 PM	★	★
Diff 2	5047	30f9ac4	Second attempt	Jul 9 2016, 6:41 PM	★	★
Diff 3	5067	dd97537	Rebase on latest master	Jul 10 2016, 5:44 PM	★	★
Diff 4	5214	6d7a4cf	rKDEVELOP9cb910b95eee4f59392b5a9ff63e897485c36fce	Jul 15 2016, 5:32 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
020fe0618cca	00e164305c5f	36f5a0774df0	Peifeng Yu	Make gdb plugin unit tests more reliable. (Show More…)	Jun 23 2016, 7:30 PM
36f5a0774df0	a00e1f4eb544	cbd8f3233674	Peifeng Yu	Move unit test debugees to common folder, make gdb uses common unit test helpers	Jun 22 2016, 6:40 PM
cbd8f3233674	d5014af2ea96	97bb04342a2d	Peifeng Yu	Common unit test helpers for gdb and lldb plugin	Jun 22 2016, 6:38 PM

Improve gdb plugin unit testsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 4693

debuggers/CMakeLists.txt

debuggers/common/CMakeLists.txt

debuggers/common/unittest/debugees/CMakeLists.txt

debuggers/common/unittest/debugees/debugee space.cpp

debuggers/common/unittest/debugees/debugee.cpp

debuggers/common/unittest/debugees/debugeecrash.cpp

debuggers/common/unittest/debugees/debugeeexception.cpp

debuggers/common/unittest/debugees/debugeemultilocbreakpoint.cpp

debuggers/common/unittest/debugees/debugeemultiplebreakpoint.cpp

debuggers/common/unittest/debugees/debugeeqt.cpp

debuggers/common/unittest/debugees/debugeerecursion.cpp

debuggers/common/unittest/debugees/debugeeslow.cpp

debuggers/common/unittest/debugees/debugeethreads.cpp

debuggers/common/unittest/debugees/path with space/CMakeLists.txt

debuggers/common/unittest/debugees/path with space/spacedebugee.cpp

debuggers/common/unittest/unittest.h

debuggers/common/unittest/unittest.cpp

debuggers/gdb/CMakeLists.txt

debuggers/gdb/unittests/CMakeLists.txt

debuggers/gdb/unittests/debugee space.cpp

debuggers/gdb/unittests/debugee.cpp

debuggers/gdb/unittests/debugeecrash.cpp

debuggers/gdb/unittests/debugeeexception.cpp

debuggers/gdb/unittests/debugeemultilocbreakpoint.cpp

debuggers/gdb/unittests/debugeemultiplebreakpoint.cpp

debuggers/gdb/unittests/debugeeqt.cpp

debuggers/gdb/unittests/debugeerecursion.cpp

debuggers/gdb/unittests/debugeeslow.cpp

debuggers/gdb/unittests/debugeethreads.cpp

debuggers/gdb/unittests/path with space/CMakeLists.txt

debuggers/gdb/unittests/path with space/spacedebugee.cpp

debuggers/gdb/unittests/test_gdb.h

debuggers/gdb/unittests/test_gdb.cpp

Improve gdb plugin unit tests
ClosedPublic
Actions

Revision Contents
Changeset List