The two-argument constructor for that, where a QWebEngineProfile is provided, was deprecated by D19559. This changes ArticleViewerWebEngine to use the single-argument constructor, which creates a private profile and handles the management of it.
- Group Reviewers
- R201:b2604e50af39: Use single-argument constructor of WebEngineViewer::WebEnginePage
Built Akregator with this change, observed correct viewing and opening of articles in tabs and inline.
Not sure if there is an explicit KDE or PIM coding standard for this, but I'd always believed that it was good programming practice for any class with virtual functions or anything derived from one (i.e. any class derived from QObject) to have a virtual destructor. Yes, the destructor is automatically virtual anyway (because QObject's is), but it changes nothing and makes the intention clear if the derived class destructor is marked as explicitly virtual. However, if the preferred standard now is to use override and not virtual, then I'm happy to adopt that.