Differential D19851

[kirigami] make it compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Mar 18 2019, 12:49 PM.

Details

Reviewers
dfaure
mart
Commits
R169:12fb6c5de392: [kirigami] make it compile without foreach
Summary

compile without foreach

Test Plan

autotest ok

Diff Detail

Repository
R169 Kirigami
Branch
compile_without_foreach (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9785
Build 9803: arc lint + arc unit
mlaurent created this revision.Mar 18 2019, 12:49 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 18 2019, 12:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mlaurent requested review of this revision.Mar 18 2019, 12:49 PM
apol added a subscriber: apol.Mar 18 2019, 2:32 PM
apol added inline comments.
src/kirigamiplugin.cpp
48

qAsConst isn't necessary because the method is already const.
Is it just for readability?

mlaurent added inline comments.Mar 18 2019, 4:17 PM
src/kirigamiplugin.cpp
48

Yep just for readability. It's just for avoiding that we thing it will detach.
For sure here it will not detach.

mart accepted this revision.Mar 19 2019, 11:31 AM
This revision is now accepted and ready to land.Mar 19 2019, 11:31 AM
Closed by commit R169:12fb6c5de392: [kirigami] make it compile without foreach (authored by mlaurent). · Explain WhyMar 19 2019, 12:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/kirigamiplugin.cpp (2 lines)

Diff 54207

View Options

CMakeLists.txt

Loading...
View Options

src/kirigamiplugin.cpp

Loading...