[kirigami] make it compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Mar 18 2019, 12:49 PM.

Details

Reviewers

dfaure
mart

Commits

Summary

compile without foreach

Test Plan

autotest ok

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mlaurent requested review of this revision.Mar 18 2019, 12:49 PM

apol added inline comments.

src/kirigamiplugin.cpp
48	qAsConst isn't necessary because the method is already const. Is it just for readability?

src/kirigamiplugin.cpp
48	Yep just for readability. It's just for avoiding that we thing it will detach. For sure here it will not detach.

This revision is now accepted and ready to land.Mar 19 2019, 11:31 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/kirigamiplugin.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	54207	c2127ae		Mar 18 2019, 12:49 PM	★	★
Diff 2	54311	fc77508	R169:12fb6c5de392dc6b6da948f1cf4dfdc386e708bd	Mar 19 2019, 12:46 PM	★	★